Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 8394022: use the userAgent() in the same loadable module as RendererWebKitPlatformSupportImpl (Closed)

Created:
9 years, 2 months ago by Dirk Pranke
Modified:
9 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

use the userAgent() in the same loadable module as RendererWebKitPlatformSupportImpl In the component build, webkit_glue may be linked into multiple modules. This can cause problems if we initialize the global variable in one module but try to read it from others (which often happens in browser_tests, where the WebKitPlatformSupport impl currently picks up the version of glue linked into chrome.dll). This change ensures that callers using content's default implementation of WebKitPlatformSupport will use the correct instance of the function. R=jam@chromium.org BUG=90442 TEST=most browser_tests pass w/ content component build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
lgtm
9 years, 2 months ago (2011-10-25 23:47:59 UTC) #1
jam
9 years, 2 months ago (2011-10-25 23:47:59 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698