Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7281)

Unified Diff: chrome/browser/resources/print_preview/margins_ui.js

Issue 8394020: Print Preview: Improving accessibility of margins UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview/margins.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/margins_ui.js
diff --git a/chrome/browser/resources/print_preview/margins_ui.js b/chrome/browser/resources/print_preview/margins_ui.js
index 8f142c59b04e672021a59852e58d77ddaf4809d7..9106bc8d0dbd3988e548f893e981fee2c13c1b98 100644
--- a/chrome/browser/resources/print_preview/margins_ui.js
+++ b/chrome/browser/resources/print_preview/margins_ui.js
@@ -107,13 +107,16 @@ cr.define('print_preview', function() {
*/
show: function() {
this.hidden = false;
+ this.classList.remove('invisible');
},
/**
- * Hides the margins UI.
+ * Hides the margins UI and removes from the DOM if requested.
+ * @param {boolean} removeFromDOM True if |this| should also be removed from
Lei Zhang 2011/10/26 00:51:48 Technically it's still in the DOM, just hidden.
dpapad 2011/10/26 01:24:24 Yes, display: none; prevents it from being rendere
+ * the DOM (in order to not interfere with the tab order).
*/
- hide: function() {
- this.hidden = true;
+ hide: function(removeFromDOM) {
+ removeFromDOM ? this.hidden = true : this.classList.add('invisible');
},
/**
« no previous file with comments | « chrome/browser/resources/print_preview/margins.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698