Print Preview: Improving accessibility of margins UI.

Print Preview: Improving accessibility of margins UI.

Keeping margin textboxes in the DOM even when not visible so that they can be
accessed by hitting the tab key. Also making margins UI visible when a textbox
gains focus (using the tab-key).

BUG=101517
TEST=Open print preview, select custom margins hover to the preview area and
back to the settings area (marginsUI should be hidden). Now hit tab key until a
margin textbox gains focus, the UI should be visible again.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107289

[dpapad, 2011-10-25 22:29:35]

Addressing item1 in the bug description.

[Lei Zhang, 2011-10-26 00:51:48]

lgtm

http://codereview.chromium.org/8394020/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/margins_ui.js (right):

http://codereview.chromium.org/8394020/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/margins_ui.js:115: * @param {boolean}
removeFromDOM True if |this| should also be removed from
Technically it's still in the DOM, just hidden.

[dpapad, 2011-10-26 01:24:24]

http://codereview.chromium.org/8394020/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/margins_ui.js (right):

http://codereview.chromium.org/8394020/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/margins_ui.js:115: * @param {boolean}
removeFromDOM True if |this| should also be removed from
On 2011/10/26 00:51:48, Lei Zhang wrote:
> Technically it's still in the DOM, just hidden.

Yes, display: none; prevents it from being rendered, I made this more clear.

[commit-bot: I haz the power, 2011-10-26 01:31:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpapad@chromium.org/8394020/1006

[commit-bot: I haz the power, 2011-10-26 02:37:31]

Change committed as 107289