[Aura] A temp app list window.

[Aura] A temp app list window.

A temp app list window that uses NTP4.

BUG=98308
TEST=Wait till real webui is implemented to verify 98308.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108011

[sky, 2011-10-25 17:59:27]

You'll also want to make it so that if the user clicks on empty space we exit
the app list.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
File chrome/browser/ui/views/aura/app_list_window.cc (right):

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:25: aura::Desktop*
desktop_window = aura::Desktop::GetInstance();
Go through screen instead of this. That way you can offset by the work area.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:32: }
nit:  // namespace

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:102: widget_ = new
views::Widget;
Users might go a long time before using the app list, so I think we should
destroy it between uses.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:112: animation_.reset(new
ui::SlideAnimation(this));
You should be able to accomplish both of these by animating the layer directly.
The animation code is in flux right now. Currently you can get this effect by:

layer->SetAnimation(animation whose only value matters is time).
layer->SetOpacity(target_opacity);
layer->SetBounds(target_bounds);

It'll change slightly once Ian lands the animation changes, but not much.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:154: void
AppListWindow::Toggle() {
Make order of methods match order in header.

[sky, 2011-10-25 18:00:09]

On 2011/10/25 17:59:27, sky wrote:
> You'll also want to make it so that if the user clicks on empty space we exit
> the app list.

Don't feel you have to do this now. If you want to push to later, add a todo.

  -Scott

>
http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
> File chrome/browser/ui/views/aura/app_list_window.cc (right):
> 
>
http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
> chrome/browser/ui/views/aura/app_list_window.cc:25: aura::Desktop*
> desktop_window = aura::Desktop::GetInstance();
> Go through screen instead of this. That way you can offset by the work area.
> 
>
http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
> chrome/browser/ui/views/aura/app_list_window.cc:32: }
> nit:  // namespace
> 
>
http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
> chrome/browser/ui/views/aura/app_list_window.cc:102: widget_ = new
> views::Widget;
> Users might go a long time before using the app list, so I think we should
> destroy it between uses.
> 
>
http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
> chrome/browser/ui/views/aura/app_list_window.cc:112: animation_.reset(new
> ui::SlideAnimation(this));
> You should be able to accomplish both of these by animating the layer
directly.
> The animation code is in flux right now. Currently you can get this effect by:
> 
> layer->SetAnimation(animation whose only value matters is time).
> layer->SetOpacity(target_opacity);
> layer->SetBounds(target_bounds);
> 
> It'll change slightly once Ian lands the animation changes, but not much.
> 
>
http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
> chrome/browser/ui/views/aura/app_list_window.cc:154: void
> AppListWindow::Toggle() {
> Make order of methods match order in header.

[xiyuan, 2011-10-27 22:51:29]

CL updated.

There are quite some remaining issues but I am not sure if I should wait till
all moving parts are landed.

1. Show animation is janky and most of the time animation finishes before WebUI
finishes first render (will fix that after
http://codereview.chromium.org/8417005/ is landed);

2. Widget is not properly closed after hide animation. Using a timer now and
will fix that after the animation framework change is landed;

3. Background browser windows are not hidden per mock;

4. Entering overview mode does not dismiss the app list;

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
File chrome/browser/ui/views/aura/app_list_window.cc (right):

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:25: aura::Desktop*
desktop_window = aura::Desktop::GetInstance();
On 2011/10/25 17:59:27, sky wrote:
> Go through screen instead of this. That way you can offset by the work area.

Done.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:32: }
On 2011/10/25 17:59:27, sky wrote:
> nit:  // namespace

Done.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:102: widget_ = new
views::Widget;
On 2011/10/25 17:59:27, sky wrote:
> Users might go a long time before using the app list, so I think we should
> destroy it between uses.

Done. Closes the window instead of hiding now.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:112: animation_.reset(new
ui::SlideAnimation(this));
On 2011/10/25 17:59:27, sky wrote:
> You should be able to accomplish both of these by animating the layer
directly.
> The animation code is in flux right now. Currently you can get this effect by:
> 
> layer->SetAnimation(animation whose only value matters is time).
> layer->SetOpacity(target_opacity);
> layer->SetBounds(target_bounds);
> 
> It'll change slightly once Ian lands the animation changes, but not much.

Sort of done. Added a TODO to properly close window once the animation ended
notification code is landed.

http://codereview.chromium.org/8394003/diff/1/chrome/browser/ui/views/aura/ap...
chrome/browser/ui/views/aura/app_list_window.cc:154: void
AppListWindow::Toggle() {
On 2011/10/25 17:59:27, sky wrote:
> Make order of methods match order in header.

Done.

[sky, 2011-10-27 23:52:34]

I think this is fine for a starting point. Don't forget about closing when the
user clicks some where else.

LGTM

http://codereview.chromium.org/8394003/diff/5001/chrome/browser/ui/views/aura...
File chrome/browser/ui/views/aura/app_list_window.h (right):

http://codereview.chromium.org/8394003/diff/5001/chrome/browser/ui/views/aura...
chrome/browser/ui/views/aura/app_list_window.h:22: static void Show(bool show);
Show(false) is a bit weird. Either name it SetVisible(bool) or provide Show and
Hide.

[commit-bot: I haz the power, 2011-10-31 19:58:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8394003/10001

[commit-bot: I haz the power, 2011-10-31 21:21:28]

Change committed as 108011