Fixed leak in ExtensionBookmarksTest.

Fixed leak in ExtensionBookmarksTest.

BUG=101468
TEST=ExtensionBookmarksTest.* passes and doesn't leak a DictionaryValue


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107132

[Joao da Silva, 2011-10-25 14:38:21]

@sky: Please review (added as owner of bookmarks/)

@timurrrr: FYI, as reporter of 101468

[sky, 2011-10-25 14:57:16]

LGTM

http://codereview.chromium.org/8394001/diff/1/chrome/browser/bookmarks/bookma...
File chrome/browser/bookmarks/bookmark_extension_helpers_unittest.cc (right):

http://codereview.chromium.org/8394001/diff/1/chrome/browser/bookmarks/bookma...
chrome/browser/bookmarks/bookmark_extension_helpers_unittest.cc:5: #include
"testing/gtest/include/gtest/gtest.h"
test files follow the same include order as .cc files. So, the first include
here should be for bookmark_extension_helpers.h, newline, then sorted includes.

http://codereview.chromium.org/8394001/diff/1/chrome/browser/bookmarks/bookma...
chrome/browser/bookmarks/bookmark_extension_helpers_unittest.cc:36:
scoped_ptr<DictionaryValue> tree;
nit: pass the value to the constructor for all of these, eg:

scoped_ptr<DictionaryValue> tree(bookmark_extension_helpers:...

[Joao da Silva, 2011-10-25 15:03:22]

Thanks for reviewing.

http://codereview.chromium.org/8394001/diff/1/chrome/browser/bookmarks/bookma...
File chrome/browser/bookmarks/bookmark_extension_helpers_unittest.cc (right):

http://codereview.chromium.org/8394001/diff/1/chrome/browser/bookmarks/bookma...
chrome/browser/bookmarks/bookmark_extension_helpers_unittest.cc:5: #include
"testing/gtest/include/gtest/gtest.h"
On 2011/10/25 14:57:17, sky wrote:
> test files follow the same include order as .cc files. So, the first include
> here should be for bookmark_extension_helpers.h, newline, then sorted
includes.

Done.

http://codereview.chromium.org/8394001/diff/1/chrome/browser/bookmarks/bookma...
chrome/browser/bookmarks/bookmark_extension_helpers_unittest.cc:36:
scoped_ptr<DictionaryValue> tree;
On 2011/10/25 14:57:17, sky wrote:
> nit: pass the value to the constructor for all of these, eg:
> 
> scoped_ptr<DictionaryValue> tree(bookmark_extension_helpers:...

Done.

[commit-bot: I haz the power, 2011-10-25 15:03:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8394001/8

[commit-bot: I haz the power, 2011-10-25 16:19:16]

Change committed as 107132