Share an instance of the ibus factory between all ibus engines.

Share an instance of the ibus factory between all ibus engines.


R=penghuang@chromium.org
BUG=chromium-os:22107
TEST=Install two IME extensions, and ensure that they both work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107682

[Peng, 2011-10-26 17:53:21]

http://codereview.chromium.org/8393038/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/ibus_engine_controller.cc (right):

http://codereview.chromium.org/8393038/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/ibus_engine_controller.cc:624: g_factory_ =
ibus_factory_new(ibus_bus_get_connection(bus));
I only find you create g_factory in connected signal handler. So I am wandering
if ibus-daemon can be started before chrome. If the answer is true,
ibus_bus_new() will return a connected bus object, and you will not get the
connected signal I think.

[Zachary Kuznia, 2011-10-27 07:25:11]

http://codereview.chromium.org/8393038/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/ibus_engine_controller.cc (right):

http://codereview.chromium.org/8393038/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/ibus_engine_controller.cc:624: g_factory_ =
ibus_factory_new(ibus_bus_get_connection(bus));
On 2011/10/26 17:53:21, Peng wrote:
> I only find you create g_factory in connected signal handler. So I am
wandering
> if ibus-daemon can be started before chrome. If the answer is true,
> ibus_bus_new() will return a connected bus object, and you will not get the
> connected signal I think.

Done.

[Peng, 2011-10-27 12:26:54]

lgtm

[commit-bot: I haz the power, 2011-10-28 03:44:00]

No LGTM from valid reviewers yet.