Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 8393032: Disable the Courgette ensemble unittest. (Closed)

Created:
9 years, 1 month ago by dgarrett
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable the Courgette ensemble unittest. This test is taking about 7 minutes to run on windows trybots and buildbots, so disabling (but not removing it) for the time being. BUG=None TEST=Ran Unitests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107288

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revamp to correctly mark as disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M courgette/ensemble_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dgarrett
Disabling that unittest for all platforms for now.
9 years, 1 month ago (2011-10-26 00:23:50 UTC) #1
nsylvain
http://codereview.chromium.org/8393032/diff/1/courgette/ensemble_unittest.cc File courgette/ensemble_unittest.cc (right): http://codereview.chromium.org/8393032/diff/1/courgette/ensemble_unittest.cc#newcode70 courgette/ensemble_unittest.cc:70: TEST_F(EnsembleTest, All) { Please just set the name to ...
9 years, 1 month ago (2011-10-26 00:30:03 UTC) #2
dgarrett
PTAL
9 years, 1 month ago (2011-10-26 00:50:48 UTC) #3
nsylvain
lgtm
9 years, 1 month ago (2011-10-26 01:01:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8393032/3
9 years, 1 month ago (2011-10-26 01:02:44 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-10-26 02:35:10 UTC) #6
Change committed as 107288

Powered by Google App Engine
This is Rietveld 408576698