Flipping the order of BackgroundModeManager and StatusTray members so that the StatusTray is not ...

Flipping the order of BackgroundModeManager and StatusTray members so that the StatusTray is not deleted before the BackgroundModeManager. Technically this should not be an issue, but it can occur if the NOTIFICATION_APP_TERMINATING notification is not sent.

BUG=101082
TEST=passes existing, but there are no repro steps for the crash to test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107644

[Andrew T Wilson (Slow), 2011-10-26 01:05:48]

lgtm

[rpetterson, 2011-10-27 05:14:43]

Something about flipping this order causes several of the interactive_ui_tests
to hang.

atw, any ideas? There's nothing about the status_tray that should depend on the
background_mode_manager. I tried manually calling reset on both pointers in the
desired order in order to get them to delete in the correct order, but that had
no effect as well.

[Andrew T Wilson (Slow), 2011-10-27 18:36:07]

No ideas offhand, but I'll give it a try locally and see if I can figure out
anything.

[rpetterson, 2011-10-27 19:17:12]

On 2011/10/27 18:36:07, Andrew T Wilson wrote:
> No ideas offhand, but I'll give it a try locally and see if I can figure out
> anything.

Just to update the CL, the failures appear to be unrelated to the change.

[commit-bot: I haz the power, 2011-10-27 20:33:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlp@chromium.org/8393028/5002

[commit-bot: I haz the power, 2011-10-27 21:28:46]

Try job failure for 8393028-5002 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-10-27 21:29:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlp@chromium.org/8393028/5002

[commit-bot: I haz the power, 2011-10-27 22:50:26]

Change committed as 107644