Bitcode streaming

include/llvm/Support/IRReader.h

 //===---- llvm/Support/IRReader.h - Reader for LLVM IR files ----*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file defines functions for reading LLVM IR. They support both
 // Bitcode and Assembly, automatically detecting the input format.
 //
 // These functions must be defined in a header file in order to avoid
 // library dependencies, since they reference both Bitcode and Assembly
 // functions.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_SUPPORT_IRREADER_H
 #define LLVM_SUPPORT_IRREADER_H
 
 #include "llvm/ADT/OwningPtr.h"
 #include "llvm/Assembly/Parser.h"
+#include "llvm/Bitcode/BitcodeStream.h"

[nlewycky, 2011/11/05 00:45:06]

Given that there's no other changes in the file, this can't be right. Either
other things we're #include'ing are missing the header, or other things
including us are (or neither, and we can just delete this line).

See http://llvm.org/docs/CodingStandards.html#hl_dontinclude .

[(google.com) Derek Schuff, 2011/11/07 22:33:50]

Sorry, this was leftover from a previous iteration where I did change this file.
Removed.

On 2011/11/05 00:45:06, nlewycky wrote:

 #include "llvm/Bitcode/ReaderWriter.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/SourceMgr.h"
 #include "llvm/Support/system_error.h"
 
 namespace llvm {
 
   /// If the given MemoryBuffer holds a bitcode image, return a Module for it
   /// which does lazy deserialization of function bodies.  Otherwise, attempt to
   /// parse it as LLVM Assembly and return a fully populated Module. This
@@ skipping 69 matching lines @@
                          "Could not open input file: " + ec.message());
       return 0;
     }
 
     return ParseIR(File.take(), Err, Context);
   }
 
 }
 
 #endif