Issue 8393003: Handlify simple functions of [keyed] store stub compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8393003: Handlify simple functions of [keyed] store stub compiler. (Closed)

Created:
9 years, 2 months ago by ulan

Modified:
9 years, 2 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Handlify simple functions of [keyed] store stub compiler. Handlified functions: CompileStoreField, CompileStoreGlobal, CompileStoreElement, CompileStorePolymorphic. Based on 8375053. R=kmillikin@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9791

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -300 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	14 chunks	+41 lines, -56 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	13 chunks	+42 lines, -55 lines	0 comments	Download
M	src/list.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/list-inl.h	View	1 chunk	+0 lines, -12 lines	1 comment	Download
M	src/stub-cache.h	View	6 chunks	+9 lines, -29 lines	0 comments	Download
M	src/stub-cache.cc	View	7 chunks	+20 lines, -83 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	14 chunks	+42 lines, -57 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 2 months ago (2011-10-26 08:48:01 UTC) #2

LGTM.

http://codereview.chromium.org/8393003/diff/1/src/list-inl.h
File src/list-inl.h (left):

http://codereview.chromium.org/8393003/diff/1/src/list-inl.h#oldcode240
src/list-inl.h:240: template <class T>
Excellent!

Expand Messages | Collapse Messages