Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

Issue 8392047: Fixes issue http://code.google.com/p/dart/issues/detail?id=235. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
index d38ecd6e12fd0e7336536d5e06557fd21a09d87f..ba34b48df7933759d3158e9f9aed99a872deff4c 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
@@ -177,14 +177,6 @@ public class TypeAnalyzerTest extends TypeTestCase {
analyze("{ var s = new Sub<String>(); }");
analyze("{ Sub s = new Sub<String>(); }");
analyze("{ Sub<String> s = new Sub<String>(); }");
-
- // FYI, this is detected in the resolver, not TypeAnalyzer
- analyzeFail("{ Sub<String, String> s = new Sub(); }",
- DartCompilerErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
- analyzeFail("{ Sub<String, String> s = new Sub<String>(); }",
- DartCompilerErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
- analyzeFail("{ Sub<String, String> s; }", DartCompilerErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
- analyzeFail("{ String<String> s; }", DartCompilerErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
}
public void testMethodInvocations() {
@@ -850,8 +842,6 @@ public class TypeAnalyzerTest extends TypeTestCase {
DartCompilerErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
analyzeFail("{ int i; var x = const {'key': i = 0.42}; }",
DartCompilerErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
- analyzeFail("Map<String, int, int> map = {'foo':1};",
- DartCompilerErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
analyzeFail("{var x = const <num, num>{}; }",
DartCompilerErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
}
@@ -1234,8 +1224,6 @@ public class TypeAnalyzerTest extends TypeTestCase {
analyze("List<int> ints = ['x'];");
analyzeFail("List<int> ints = <String>['x'];",
DartCompilerErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
- analyzeFail("List<int, int> ints = [1];",
- DartCompilerErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS);
}
public void testInitializedLocals() {
« no previous file with comments | « compiler/javatests/com/google/dart/compiler/resolver/RawTypesNegativeTest.dart ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698