Document optional parameters of ...devtools.inspectedWindow.reload()

Document optional parameters of ...devtools.inspectedWindow.reload()

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107583

[caseq, 2011-10-26 17:36:34]

Live version:

http://www.corp.google.com/~caseq/devtoolsext/docs/experimental.devtools.insp...

[kathyw, 2011-10-26 18:02:23]

Some minor comments, but aside from them lgtm.

http://codereview.chromium.org/8392043/diff/1/chrome/common/extensions/api/de...
File chrome/common/extensions/api/devtools_api.json (right):

http://codereview.chromium.org/8392043/diff/1/chrome/common/extensions/api/de...
chrome/common/extensions/api/devtools_api.json:122: "description": "When true,
the loader will ignore cache for all inspected page resources loaded before the
<code>load</code> event is fired. The effect is similar to pressing Ctrl+Shift+R
in the inspected window or within the Developer Tools window."
cache -> the cache

http://codereview.chromium.org/8392043/diff/1/chrome/common/extensions/api/de...
chrome/common/extensions/api/devtools_api.json:127: "description": "If
specified, the string will override the value of <code>User-Agent</code> HTTP
header sent while loading the resources of inspected page and the value of the
<code>navigator.userAgent</code> property returned to the scripts running within
the inspected page."
This sentence is very long, is missing some articles, and could be clearer. How
about (not sure this is right, so please check!):

"If specified, the string will override the value of the <code>User-Agent</code>
HTTP header that's sent while loading the resources of inspected page. The
string will also override the value of the <code>navigator.userAgent</code>
property that's returned to any scripts that are running within the inspected
page."

http://codereview.chromium.org/8392043/diff/1/chrome/common/extensions/api/de...
chrome/common/extensions/api/devtools_api.json:132: "description": "If
specified, the script will be injected into every frame of the inspected page
immediately upon load, before any of the frame's scripts. The script will not be
injected after subsequent reloads, for example, if user presses Ctrl+R."
, for example -> &mdash;for example

[caseq, 2011-10-27 15:00:28]

On 2011/10/26 18:02:23, kathyw wrote:
> Some minor comments, but aside from them lgtm.

Thanks for the quick review, fixed everything as you suggested.

[commit-bot: I haz the power, 2011-10-27 15:00:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caseq@chromium.org/8392043/3001

[commit-bot: I haz the power, 2011-10-27 16:25:15]

Change committed as 107583