chrome/browser/prerender/prerender_manager_unittest.cc - Issue 8392041: Prerendered tabs use the same SessionStorage namespace as the tab that triggered the prerender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_manager_unittest.cc

Issue 8392041: Prerendered tabs use the same SessionStorage namespace as the tab that triggered the prerender. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix NetInternals browser test Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prerender/prerender_manager.cc ('K') | « chrome/browser/prerender/prerender_manager.cc ('k') | chrome/browser/ui/webui/net_internals_ui_browsertest.cc » ('j') | chrome/test/data/prerender/prerender_loader_with_session_storage.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prerender/prerender_manager_unittest.cc

diff --git a/chrome/browser/prerender/prerender_manager_unittest.cc b/chrome/browser/prerender/prerender_manager_unittest.cc

index 28cf9f0874f9b2ae9bb1ca6f2860a3dbd00dd8a9..c031a0b2074bdc37fbd05579616a571bd3f43958 100644

--- a/chrome/browser/prerender/prerender_manager_unittest.cc

+++ b/chrome/browser/prerender/prerender_manager_unittest.cc

@@ -22,9 +22,11 @@ class DummyPrerenderContents : public PrerenderContents {

public:

DummyPrerenderContents(PrerenderManager* prerender_manager,

PrerenderTracker* prerender_tracker,

+ SessionStorageNamespace* session_storage_namespace,

const GURL& url,

FinalStatus expected_final_status)

- : PrerenderContents(prerender_manager, prerender_tracker, NULL, url,

+ : PrerenderContents(prerender_manager, prerender_tracker,

+ session_storage_namespace, NULL, url,

GURL(), ORIGIN_LINK_REL_PRERENDER,

PrerenderManager::kNoExperiment),

has_started_(false),

@@ -99,7 +101,7 @@ class TestPrerenderManager : public PrerenderManager {

const GURL& url,

FinalStatus expected_final_status) {

DummyPrerenderContents* prerender_contents =

- new DummyPrerenderContents(this, prerender_tracker_, url,

+ new DummyPrerenderContents(this, prerender_tracker_, NULL, url,

expected_final_status);

SetNextPrerenderContents(prerender_contents);

return prerender_contents;

@@ -110,7 +112,7 @@ class TestPrerenderManager : public PrerenderManager {

const std::vector<GURL>& alias_urls,

FinalStatus expected_final_status) {

DummyPrerenderContents* prerender_contents =

- new DummyPrerenderContents(this, prerender_tracker_, url,

+ new DummyPrerenderContents(this, prerender_tracker_, NULL, url,

expected_final_status);

for (std::vector<GURL>::const_iterator it = alias_urls.begin();

it != alias_urls.end();

@@ -153,6 +155,7 @@ class TestPrerenderManager : public PrerenderManager {

}

virtual PrerenderContents* CreatePrerenderContents(

+ SessionStorageNamespace* session_storage_namespace,

const GURL& url,

const GURL& referrer,

Origin origin,