Issue 8392038: A more holistic test case for proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8392038: A more holistic test case for proxies. (Closed)

Created:
9 years, 1 month ago by rossberg

Modified:
9 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

A more holistic test case for proxies. Depends on http://codereview.chromium.org/8318014/ R=mstarzinger@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9961

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+510 lines, -0 lines)			Patch
	A	test/mjsunit/harmony/proxies-example-membrane.js	View		1 chunk	+510 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

9 years, 1 month ago (2011-10-28 12:08:34 UTC) #2

LGTM. I like tests. It currently fails with the recent fixes to assertSame, so
please add it to mjsunit.status in case it still fails when landing.

http://codereview.chromium.org/8392038/diff/1/test/mjsunit/harmony/proxies-ex...
File test/mjsunit/harmony/proxies-example-membrane.js (right):

http://codereview.chromium.org/8392038/diff/1/test/mjsunit/harmony/proxies-ex...
test/mjsunit/harmony/proxies-example-membrane.js:32: //
http://wiki.ecmascript.org/doku.php?id=harmony:proxies#examplea_no-op_forward...
I am not sure about the policy for long URLs in comments. If it is OK to have
more than 80 chars per line here then I am fine with it.

http://codereview.chromium.org/8392038/diff/1/test/mjsunit/harmony/proxies-ex...
test/mjsunit/harmony/proxies-example-membrane.js:284: //
http://wiki.ecmascript.org/doku.php?id=harmony:proxies#an_identity-preserving...
Likewise.

Expand Messages | Collapse Messages