Fix error handling in Date.prototype.toISOString.

Fix error handling in Date.prototype.toISOString.

This fixes Date.prototyoe.toISOString to throw a RangeError exception
for invalid time values. It also includes a fix to removes the arbitrary
(and completely bogus) range limit on the date value during construction
of a Date object. Note that we still have bogus range limits on the year
and month values.

R=lrn@chromium.org
BUG=v8:1792
TEST=mjsunit/date,test262/15.9.5.43-0-*

Committed: http://code.google.com/p/v8/source/detail?r=9829

[Michael Starzinger, 2011-10-26 15:11:44]

PTAL.

[Lasse Reichstein, 2011-10-27 07:11:01]

While we match the current state of Safari, I can see that both Firefox 6. and
IE 9 already throws the RangeError now.
I'm not sure we should consider this an OK failure for test262. Perhaps we
should rather be fixing it.

http://codereview.chromium.org/8392036/diff/1/test/test262/test262.status
File test/test262/test262.status (right):

http://codereview.chromium.org/8392036/diff/1/test/test262/test262.status#new...
test/test262/test262.status:135: # string is not a finite number. This is
compatible with Firefox and
"string is not a finite number" makes no sense. 
The spec says "if the time value of this date is not a finite number" (i.e.,
it's NaN).

Do say what we do instead (we don't throw, we just return the string "Invalid
Date".

[Michael Starzinger, 2011-10-27 15:12:08]

Added new patch set that actually fixes the issue. Updated description. PTAL.

[Lasse Reichstein, 2011-10-28 07:20:54]

LGTM!

http://codereview.chromium.org/8392036/diff/5001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8392036/diff/5001/src/runtime.cc#newcode7530
src/runtime.cc:7530: if (year % 4 || (year % 100 == 0 && year % 400 != 0)) {
Could we make this ((year % 4) != 0 || ....
I dislike implicit interger->boolean conversion :)

http://codereview.chromium.org/8392036/diff/5001/test/mjsunit/date.js
File test/mjsunit/date.js (right):

http://codereview.chromium.org/8392036/diff/5001/test/mjsunit/date.js#newcode160
test/mjsunit/date.js:160: assertDoesNotThrow("new Date(-0, -0, -0, -0, -0, -0,
-0)");
Good catch!

[Michael Starzinger, 2011-10-28 08:46:35]

Added new patch set. Landed.

http://codereview.chromium.org/8392036/diff/5001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8392036/diff/5001/src/runtime.cc#newcode7530
src/runtime.cc:7530: if (year % 4 || (year % 100 == 0 && year % 400 != 0)) {
On 2011/10/28 07:20:54, Lasse Reichstein wrote:
> Could we make this ((year % 4) != 0 || ....
> I dislike implicit interger->boolean conversion :)

Done.