Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 8392025: Fix Javascript typo in LazyBackgroundPageApiTest (Closed)

Created:
9 years, 1 month ago by Tessa MacDuff
Modified:
9 years, 1 month ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix Javascript typo in LazyBackgroundPageApiTest BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107850

Patch Set 1 #

Total comments: 2

Patch Set 2 : use usual pattern for search() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Tessa MacDuff
Oops. I suck at Javascript.
9 years, 1 month ago (2011-10-26 01:11:16 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/8392025/diff/1/chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html File chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html (right): http://codereview.chromium.org/8392025/diff/1/chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html#newcode4 chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html:4: if (tab.url.search("stegosaurus") >= 0) The usual pattern for ...
9 years, 1 month ago (2011-10-28 23:30:31 UTC) #2
Tessa MacDuff
http://codereview.chromium.org/8392025/diff/1/chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html File chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html (right): http://codereview.chromium.org/8392025/diff/1/chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html#newcode4 chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.html:4: if (tab.url.search("stegosaurus") >= 0) On 2011/10/28 23:30:31, Aaron Boodman ...
9 years, 1 month ago (2011-10-28 23:33:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tessamac@chromium.org/8392025/4002
9 years, 1 month ago (2011-10-29 00:15:58 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-29 02:07:48 UTC) #5
Change committed as 107850

Powered by Google App Engine
This is Rietveld 408576698