chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm - Issue 8392017: Change string16 to std::string in the gfx::Font() interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

Issue 8392017: Change string16 to std::string in the gfx::Font() interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix mac unit tests Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

index 178acec89df1cd7d164e1ca1f6762a1168795054..40c0cc6a1cdca85c3a5f52c9d7020453c0bdfc49 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

@@ -27,7 +27,7 @@ class OmniboxPopupViewMacTest : public PlatformTest {

color_ = [NSColor blackColor];

dimColor_ = [NSColor darkGrayColor];

font_ = gfx::Font(

- base::SysNSStringToUTF16([[NSFont userFontOfSize:12] fontName]), 12);

+ base::SysNSStringToUTF8([[NSFont userFontOfSize:12] fontName]), 12);

}

// Returns the length of the run starting at |location| for which