chrome/browser/metrics/metrics_service.cc - Issue 8392010: Fix use-after-free that resulted from r106949.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 8392010: Fix use-after-free that resulted from r106949. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_service.cc

===================================================================

--- chrome/browser/metrics/metrics_service.cc (revision 107151)

+++ chrome/browser/metrics/metrics_service.cc (working copy)

@@ -1072,7 +1072,8 @@

DCHECK(waiting_for_asynchronus_reporting_step_);

waiting_for_asynchronus_reporting_step_ = false;

DCHECK(current_fetch_.get());

- current_fetch_.reset(NULL); // We're not allowed to re-use it.

+ // We're not allowed to re-use it. Delete it on function exit since we use it.

+ scoped_ptr<content::URLFetcher> s(current_fetch_.release());

// Confirm send so that we can move on.

VLOG(1) << "METRICS RESPONSE CODE: " << source->GetResponseCode()

« no previous file with comments | « no previous file | chrome/browser/tab_contents/spelling_menu_observer.cc » ('j') | no next file with comments »