Handlify the remaining CallStubCompiler functions.

Handlify the remaining CallStubCompiler functions.

Also, handlify functions for loading with interceptors and callbacks.
Remove some unneeded code.  Rename Foreign::address() because it
confusingly shadows HeapObject::address() which does something quite
different.

R=vegorov@chromium.org,ulan@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9834

[Kevin Millikin (Chromium), 2011-10-26 15:51:52]

This change is so big because these functions all shared helpers and utilities.

[ulan, 2011-10-27 10:10:26]

LGTM.

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (left):

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc#oldco...
src/arm/stub-cache-arm.cc:2686: UNREACHABLE();
Wouldn't it be helpful in future if CheckType is extended?

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:1156: // Emitting a stub call may try to allocate (if
the code is not
Old comment.

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:1196: compile_followup_inline =
Nitpick: the old code does (compile_followup_inline |= ...).

[Kevin Millikin (Chromium), 2011-10-27 10:53:43]

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (left):

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc#oldco...
src/arm/stub-cache-arm.cc:2686: UNREACHABLE();
On 2011/10/27 10:10:26, ulan wrote:
> Wouldn't it be helpful in future if CheckType is extended?

Actually the opposite.

default: UNREACHABLE() can hide bugs, because it relies on test coverage in
debug builds to hit it.

No default clause will be a compilation error if CheckType is extended,
conveniently identifying this site that the programmer has to inspect.

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:1156: // Emitting a stub call may try to allocate (if
the code is not
On 2011/10/27 10:10:26, ulan wrote:
> Old comment.

Thanks.

http://codereview.chromium.org/8391045/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:1196: compile_followup_inline =
On 2011/10/27 10:10:26, ulan wrote:
> Nitpick: the old code does (compile_followup_inline |= ...).

There's no reason to preserve the implementation.