chrome/browser/task_manager/task_manager_resource_providers.h - Issue 8391039: TaskManager: introduce Resource::(Can)Inspect; support tabs, apps, extensions and notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.h

Issue 8391039: TaskManager: introduce Resource::(Can)Inspect; support tabs, apps, extensions and notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Self-review. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/task_manager/main.js ('K') | « chrome/browser/task_manager/task_manager_notification_resource_provider.cc ('k') | chrome/browser/task_manager/task_manager_resource_providers.cc » ('j') | chrome/browser/ui/webui/task_manager_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_resource_providers.h

diff --git a/chrome/browser/task_manager/task_manager_resource_providers.h b/chrome/browser/task_manager/task_manager_resource_providers.h

index e4b7aeed21bf0e3a298dcfdaaa20cf27001930bb..a45b7c9318f769361ae0c35161e00df2c042cb52 100644

--- a/chrome/browser/task_manager/task_manager_resource_providers.h

+++ b/chrome/browser/task_manager/task_manager_resource_providers.h

@@ -49,6 +49,10 @@ class TaskManagerRendererResource : public TaskManager::Resource {

virtual size_t GetV8MemoryAllocated() const OVERRIDE;

virtual size_t GetV8MemoryUsed() const OVERRIDE;

+ // RenderResources are always inspectable.

+ virtual bool CanInspect() const OVERRIDE;

+ virtual void Inspect() const OVERRIDE;

// RenderResources always provide the network usage.

virtual bool SupportNetworkUsage() const;

virtual void SetSupportNetworkUsage() { }

@@ -326,6 +330,8 @@ class TaskManagerExtensionProcessResource : public TaskManager::Resource {

virtual SkBitmap GetIcon() const OVERRIDE;

virtual base::ProcessHandle GetProcess() const OVERRIDE;

virtual Type GetType() const OVERRIDE;

+ virtual bool CanInspect() const OVERRIDE;

+ virtual void Inspect() const OVERRIDE;

virtual bool SupportNetworkUsage() const OVERRIDE;

virtual void SetSupportNetworkUsage() OVERRIDE;

virtual const Extension* GetExtension() const OVERRIDE;

@@ -402,6 +408,8 @@ class TaskManagerNotificationResource : public TaskManager::Resource {

virtual SkBitmap GetIcon() const OVERRIDE;

virtual base::ProcessHandle GetProcess() const OVERRIDE;

virtual Type GetType() const OVERRIDE;

+ virtual bool CanInspect() const OVERRIDE;

+ virtual void Inspect() const OVERRIDE;

virtual bool SupportNetworkUsage() const OVERRIDE;

virtual void SetSupportNetworkUsage() OVERRIDE { }