Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.cc

Issue 8391039: TaskManager: introduce Resource::(Can)Inspect; support tabs, apps, extensions and notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self-review. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_resource_providers.cc
diff --git a/chrome/browser/task_manager/task_manager_resource_providers.cc b/chrome/browser/task_manager/task_manager_resource_providers.cc
index 5c64103adbf9d64c5b1cb5f7f0341a38b6cc106e..ad28bd5ffe23a780444e70f29fce162ed19d5678 100644
--- a/chrome/browser/task_manager/task_manager_resource_providers.cc
+++ b/chrome/browser/task_manager/task_manager_resource_providers.cc
@@ -19,6 +19,7 @@
#include "chrome/browser/background/background_contents_service.h"
#include "chrome/browser/background/background_contents_service_factory.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/debugger/devtools_window.h"
#include "chrome/browser/extensions/extension_host.h"
#include "chrome/browser/extensions/extension_process_manager.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -187,6 +188,14 @@ bool TaskManagerRendererResource::ReportsV8MemoryStats() const {
return true;
}
+bool TaskManagerRendererResource::CanInspect() const {
+ return true;
+}
+
+void TaskManagerRendererResource::Inspect() const {
+ DevToolsWindow::OpenDevToolsWindow(render_view_host_);
+}
+
bool TaskManagerRendererResource::SupportNetworkUsage() const {
return true;
}
@@ -1095,6 +1104,14 @@ TaskManagerExtensionProcessResource::GetType() const {
return EXTENSION;
}
+bool TaskManagerExtensionProcessResource::CanInspect() const {
+ return true;
+}
+
+void TaskManagerExtensionProcessResource::Inspect() const {
+ DevToolsWindow::OpenDevToolsWindow(extension_host_->render_view_host());
+}
+
bool TaskManagerExtensionProcessResource::SupportNetworkUsage() const {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698