Issue 8391039: TaskManager: introduce Resource::(Can)Inspect; support tabs, apps, extensions and notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8391039: TaskManager: introduce Resource::(Can)Inspect; support tabs, apps, extensions and notifications. (Closed)

Created:
9 years, 1 month ago by pfeldman

Modified:
9 years, 1 month ago

Reviewers:
yoshiki, yurys

CC:
chromium-reviews, arv (Not doing code reviews), yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

TaskManager: introduce Resource::(Can)Inspect; support tabs, apps, extensions and notifications. BUG=85959 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107351

Patch Set 1 #

Patch Set 2 : Self-review. #

Total comments: 3

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -17 lines)			Patch
M	chrome/browser/resources/task_manager/main.js	View	1	2 chunks	+9 lines, -1 line	2 comments	Download
M	chrome/browser/task_manager/task_manager.h	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_notification_resource_provider.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View		3 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/task_manager_handler.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/task_manager_handler.cc	View		8 chunks	+36 lines, -15 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

yurys

9 years, 1 month ago (2011-10-26 14:33:44 UTC) #1

lgtm

http://codereview.chromium.org/8391039/diff/2001/chrome/browser/resources/tas...
File chrome/browser/resources/task_manager/main.js (right):

http://codereview.chromium.org/8391039/diff/2001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:56: * Sends commands to initiate
resource inspection.
This is comment for the inspect method.

http://codereview.chromium.org/8391039/diff/2001/chrome/browser/resources/tas...
chrome/browser/resources/task_manager/main.js:65: * Sends commands to kill a
process.
Move to killProcess comments?

http://codereview.chromium.org/8391039/diff/2001/chrome/browser/ui/webui/task...
File chrome/browser/ui/webui/task_manager_handler.cc (right):

http://codereview.chromium.org/8391039/diff/2001/chrome/browser/ui/webui/task...
chrome/browser/ui/webui/task_manager_handler.cc:351: i != resource_index->end();
i++) {
++i

Expand Messages | Collapse Messages