Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8391036: Add unittests for the detection of md[2,4,5] when verifying certificates (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi
Modified:
9 years, 1 month ago
Reviewers:
palmer, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add unittests for the detection of md[2,4,5] when verifying certificates BUG=101123 TEST=net_unittests:X509CertificateWeakDigestTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108074

Patch Set 1 #

Patch Set 2 : Enable a few tests on Windows #

Patch Set 3 : Fix Linux #

Total comments: 3

Patch Set 4 : Restructure tests to fix NSS #

Total comments: 3

Patch Set 5 : Rebase #

Patch Set 6 : expand the macro expansion comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+733 lines, -9 lines) Patch
M net/base/x509_certificate_unittest.cc View 1 2 3 4 5 2 chunks +205 lines, -9 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md2_ee.pem View 1 chunk +61 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md2_intermediate.pem View 1 chunk +57 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md2_root.pem View 1 chunk +14 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md4_ee.pem View 1 chunk +61 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md4_intermediate.pem View 1 chunk +57 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md4_root.pem View 1 chunk +14 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md5_ee.pem View 1 chunk +61 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md5_intermediate.pem View 1 chunk +57 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_md5_root.pem View 1 chunk +14 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_sha1_ee.pem View 1 chunk +61 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_sha1_intermediate.pem View 1 chunk +57 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/weak_digest_sha1_root.pem View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ryan Sleevi
wtc, palmer: While this should be a trivial review, this is currently broken on Windows ...
9 years, 1 month ago (2011-10-26 05:23:29 UTC) #1
palmer
http://codereview.chromium.org/8391036/diff/2015/net/base/x509_certificate_unittest.cc File net/base/x509_certificate_unittest.cc (right): http://codereview.chromium.org/8391036/diff/2015/net/base/x509_certificate_unittest.cc#newcode1466 net/base/x509_certificate_unittest.cc:1466: void PrintTo(const WeakDigestTestData& data, std::ostream* os) { You never ...
9 years, 1 month ago (2011-10-26 19:09:15 UTC) #2
Ryan Sleevi
http://codereview.chromium.org/8391036/diff/2015/net/base/x509_certificate_unittest.cc File net/base/x509_certificate_unittest.cc (right): http://codereview.chromium.org/8391036/diff/2015/net/base/x509_certificate_unittest.cc#newcode1466 net/base/x509_certificate_unittest.cc:1466: void PrintTo(const WeakDigestTestData& data, std::ostream* os) { On 2011/10/26 ...
9 years, 1 month ago (2011-10-26 22:27:47 UTC) #3
palmer
lgtm LGTM with the indentation fix.
9 years, 1 month ago (2011-10-27 00:42:13 UTC) #4
Ryan Sleevi
wtc, palmer: This is what I get for assuming NSS will do the right thing ...
9 years, 1 month ago (2011-10-27 07:14:35 UTC) #5
palmer
lgtm http://codereview.chromium.org/8391036/diff/5002/net/base/x509_certificate_unittest.cc File net/base/x509_certificate_unittest.cc (right): http://codereview.chromium.org/8391036/diff/5002/net/base/x509_certificate_unittest.cc#newcode1521 net/base/x509_certificate_unittest.cc:1521: #define WRAPPED_INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator) \ I admit I ...
9 years, 1 month ago (2011-10-28 18:45:04 UTC) #6
Ryan Sleevi
wtc: Ping on this (rubberstamp with Palmer's feedback?). Just need an OWNERS here.
9 years, 1 month ago (2011-10-31 22:26:57 UTC) #7
wtc
Patch Set 4 LGTM. It is fine by me to not check certificate signature algorithms ...
9 years, 1 month ago (2011-10-31 23:48:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8391036/15001
9 years, 1 month ago (2011-11-01 04:04:30 UTC) #9
Ryan Sleevi
http://codereview.chromium.org/8391036/diff/5002/net/base/x509_certificate_unittest.cc File net/base/x509_certificate_unittest.cc (right): http://codereview.chromium.org/8391036/diff/5002/net/base/x509_certificate_unittest.cc#newcode1520 net/base/x509_certificate_unittest.cc:1520: // macros, like TEST or TEST_F. On 2011/10/31 23:48:00, ...
9 years, 1 month ago (2011-11-01 04:06:46 UTC) #10
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 05:13:23 UTC) #11
Change committed as 108074

Powered by Google App Engine
This is Rietveld 408576698