Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chrome/browser/sync/sync_ui_util.cc

Issue 8391034: Remove sync error button from bookmark bar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_ui_util.h ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_ui_util.cc
diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc
index f9b564a7a09bcdbee08cb4caf9befeedf6be37d0..7264b48addc47d9d5180c074389d9cfa0e5baca4 100644
--- a/chrome/browser/sync/sync_ui_util.cc
+++ b/chrome/browser/sync/sync_ui_util.cc
@@ -392,22 +392,6 @@ MessageType GetStatus(ProfileSyncService* service) {
return sync_ui_util::GetStatusInfo(service, NULL, NULL);
}
-bool ShouldShowSyncErrorButton(ProfileSyncService* service) {
- if (!service)
- return false;
-
- if (service->IsManaged() || !service->HasSyncSetupCompleted())
- return false;
-
- // Don't display error button for unrecoverable errors; they are not
- // actionable.
- if (service->unrecoverable_error_detected())
- return false;
-
- return GetStatus(service) == sync_ui_util::SYNC_ERROR ||
- service->IsPassphraseRequired();
-}
-
string16 GetSyncMenuLabel(ProfileSyncService* service) {
MessageType type = GetStatus(service);
« no previous file with comments | « chrome/browser/sync/sync_ui_util.h ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698