bisect_builds: Also print the corresponding webkit revision range.

bisect_builds: Also print the corresponding webkit revision range.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107225

[Robert Sesek, 2011-10-25 20:55:17]

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py#newcode434
tools/bisect-builds.py:434: def GetWebKitRevisionForChromiumRevision(rev):
Needs """docstring"""

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py#newcode437
tools/bisect-builds.py:437: m = webkit_re.search(urllib.urlopen(DEPS_FILE %
rev).read())
Do you need to close this?

[Nico, 2011-10-25 20:57:24]

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py#newcode434
tools/bisect-builds.py:434: def GetWebKitRevisionForChromiumRevision(rev):
On 2011/10/25 20:55:17, rsesek wrote:
> Needs """docstring"""

Done.

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py#newcode437
tools/bisect-builds.py:437: m = webkit_re.search(urllib.urlopen(DEPS_FILE %
rev).read())
On 2011/10/25 20:55:17, rsesek wrote:
> Do you need to close this?

It'll be closed when it's garbage collected or when the script exits (probably
the latter, given that this is the last thing the script does). Since this isn't
a long-running process, I figured that's good enough?

[Robert Sesek, 2011-10-25 20:59:35]

lgtm

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/8391018/diff/1/tools/bisect-builds.py#newcode437
tools/bisect-builds.py:437: m = webkit_re.search(urllib.urlopen(DEPS_FILE %
rev).read())
On 2011/10/25 20:57:24, Nico wrote:
> On 2011/10/25 20:55:17, rsesek wrote:
> > Do you need to close this?
> 
> It'll be closed when it's garbage collected or when the script exits (probably
> the latter, given that this is the last thing the script does). Since this
isn't
> a long-running process, I figured that's good enough?

OK. But add a comment to that effect because this is a deliberate fd leak, then.
Or just close it :-).

[commit-bot: I haz the power, 2011-10-25 21:03:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8391018/3

[commit-bot: I haz the power, 2011-10-25 22:58:33]

Change committed as 107225