Issue 8391011: Make sure that the builder includes the search app crx in the installer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8391011: Make sure that the builder includes the search app crx in the installer. (Closed)

Created:
9 years, 1 month ago by Roger Tawa OOO till Jul 10th

Modified:
9 years, 1 month ago

Reviewers:
commit-bot: I haz the power, robertshield

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make sure that the builder includes the search app crx in the installer. In a previous CL I added the crx file and the corresponding change to the json file, but forgot to add the crx file to the gyp files. BUG=101500 TEST=Make sure the search app appears in new profiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107263

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/default_apps/external_extensions.json	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

Hi Robert, Please take a look. Thanks,

9 years, 1 month ago (2011-10-25 18:54:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/8391011/1

9 years, 1 month ago (2011-10-25 23:39:52 UTC) #3

Change committed as 107263

Expand Messages | Collapse Messages