Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 8391003: Change O(n^2) loop to O(n) in ObserverListBase::Compact(). (Closed)

Created:
9 years, 1 month ago by Alexei Svitkine (slow)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Change O(n^2) loop to O(n) in ObserverListBase::Compact(). BUG=none TEST=Time a short program having two versions of that code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M base/observer_list.h View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexei Svitkine (slow)
9 years, 1 month ago (2011-10-25 15:25:04 UTC) #1
willchan no longer on Chromium
Great, thanks! LGTM.
9 years, 1 month ago (2011-10-25 15:49:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8391003/1
9 years, 1 month ago (2011-10-25 15:54:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8391003/1
9 years, 1 month ago (2011-10-25 16:45:26 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-25 18:00:04 UTC) #5
Change committed as 107153

Powered by Google App Engine
This is Rietveld 408576698