Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 8390059: https://code.google.com/p/dart/issues/detail?id=225 (Closed)

Created:
9 years, 1 month ago by fabiomfv
Modified:
9 years, 1 month ago
Reviewers:
mmendez
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Dart Spec v0.03, section 11.10: Generative constructors cannot return arbitrary expressions in the form: 'return e;' they can though have return statement in the form: 'return;' https://code.google.com/p/dart/issues/detail?id=225 Committed: https://code.google.com/p/dart/source/detail?r=773

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 2 chunks +16 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/ConstructorReturnNegativeTest.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A tests/language/src/ConstructorReturnTest.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fabiomfv
9 years, 1 month ago (2011-10-26 19:07:13 UTC) #1
mmendez
LGTM No need to review the pending status file changes. http://codereview.chromium.org/8390059/diff/1005/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (right): http://codereview.chromium.org/8390059/diff/1005/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java#newcode124 ...
9 years, 1 month ago (2011-10-26 19:21:49 UTC) #2
fabiomfv
9 years, 1 month ago (2011-10-26 19:27:55 UTC) #3
http://codereview.chromium.org/8390059/diff/1005/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (right):

http://codereview.chromium.org/8390059/diff/1005/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:124:
INVALID_RETURN_IN_CONSTRUCTOR("Generative constructor cannot return arbitrary
expressions"),
On 2011/10/26 19:21:49, mmendez wrote:
> Nit: constructor -> constructors

Done.

http://codereview.chromium.org/8390059/diff/1005/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:205: 
On 2011/10/26 19:21:49, mmendez wrote:
> Nit: whitespace

Done.

Powered by Google App Engine
This is Rietveld 408576698