Change the toolbar action New File to New Application to improve the UX of the Dart Editor for th...

Change the toolbar action New File to New Application to improve the UX of the Dart Editor for the initial users.

This is a fix for Issue 237 (http://code.google.com/p/dart/issues/detail?id=237).
Committed: https://code.google.com/p/dart/source/detail?r=762

[devoncarew, 2011-10-26 17:27:10]

lgtm

Looks good, one issue to take care of.

http://codereview.chromium.org/8390054/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenNewApplicationWizardAction.java
(right):

http://codereview.chromium.org/8390054/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenNewApplicationWizardAction.java:43:
setId("com.google.dart.tools.ui.app.new"); //$NON-NLS-N$
Let's make this string a constant in this file.

[jwren, 2011-10-26 17:30:45]

http://codereview.chromium.org/8390054/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenNewApplicationWizardAction.java
(right):

http://codereview.chromium.org/8390054/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/OpenNewApplicationWizardAction.java:43:
setId("com.google.dart.tools.ui.app.new"); //$NON-NLS-N$
On 2011/10/26 17:27:10, devoncarew wrote:
> Let's make this string a constant in this file.

Done.

[keertip, 2011-10-26 19:05:27]

lgtm

[danrubel, 2011-10-27 07:02:33]

lgtm