Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 8390050: Fixing performance regression in issue 1787. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6655 matching lines...) Expand 10 before | Expand all | Expand 10 after
6666 // |done| label if a property with the given name is found leaving the 6666 // |done| label if a property with the given name is found leaving the
6667 // index into the dictionary in |r0|. Jump to the |miss| label 6667 // index into the dictionary in |r0|. Jump to the |miss| label
6668 // otherwise. 6668 // otherwise.
6669 void StringDictionaryLookupStub::GeneratePositiveLookup(MacroAssembler* masm, 6669 void StringDictionaryLookupStub::GeneratePositiveLookup(MacroAssembler* masm,
6670 Label* miss, 6670 Label* miss,
6671 Label* done, 6671 Label* done,
6672 Register elements, 6672 Register elements,
6673 Register name, 6673 Register name,
6674 Register r0, 6674 Register r0,
6675 Register r1) { 6675 Register r1) {
6676 ASSERT(!elements.is(r0));
6677 ASSERT(!elements.is(r1));
6678 ASSERT(!name.is(r0));
6679 ASSERT(!name.is(r1));
6680
6676 // Assert that name contains a string. 6681 // Assert that name contains a string.
6677 if (FLAG_debug_code) __ AbortIfNotString(name); 6682 if (FLAG_debug_code) __ AbortIfNotString(name);
6678 6683
6679 __ mov(r1, FieldOperand(elements, kCapacityOffset)); 6684 __ mov(r1, FieldOperand(elements, kCapacityOffset));
6680 __ shr(r1, kSmiTagSize); // convert smi to int 6685 __ shr(r1, kSmiTagSize); // convert smi to int
6681 __ dec(r1); 6686 __ dec(r1);
6682 6687
6683 // Generate an unrolled loop that performs a few probes before 6688 // Generate an unrolled loop that performs a few probes before
6684 // giving up. Measurements done on Gmail indicate that 2 probes 6689 // giving up. Measurements done on Gmail indicate that 2 probes
6685 // cover ~93% of loads from dictionaries. 6690 // cover ~93% of loads from dictionaries.
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
7082 __ bind(&need_incremental); 7087 __ bind(&need_incremental);
7083 7088
7084 // Fall through when we need to inform the incremental marker. 7089 // Fall through when we need to inform the incremental marker.
7085 } 7090 }
7086 7091
7087 #undef __ 7092 #undef __
7088 7093
7089 } } // namespace v8::internal 7094 } } // namespace v8::internal
7090 7095
7091 #endif // V8_TARGET_ARCH_IA32 7096 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698