Issue 8390050: Fixing performance regression in issue 1787.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8390050: Fixing performance regression in issue 1787. (Closed)

Created:
9 years, 1 month ago by Yang

Modified:
9 years, 1 month ago

Reviewers:
ulan, Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixing performance regression in issue 1787. BUG=v8:1787 Committed: http://code.google.com/p/v8/source/detail?r=9812

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -2 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	2 chunks	+13 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

On ARM, when calling StringDictionaryLookupStub::GeneratePositiveLookup from KeyedLoadIC::GenerateGeneric over GenerateDictionaryLoad, the registers elements and name are ...

9 years, 1 month ago (2011-10-26 16:09:01 UTC) #1

ulan

9 years, 1 month ago (2011-10-27 07:57:20 UTC) #3

LGTM. It is scary that register usage contract is implicit in the source code.

Expand Messages | Collapse Messages