Issue 8390049: Prepare push to trunk. Now working on 3.7.2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8390049: Prepare push to trunk. Now working on 3.7.2 (Closed)

Created:
9 years, 1 month ago by Erik Corry

Modified:
9 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Chromium), Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. Now working on 3.7.2 Committed: http://code.google.com/p/v8/source/detail?r=9807

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+45 lines, -0 lines	1 comment	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

lgtm http://codereview.chromium.org/8390049/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/8390049/diff/1/ChangeLog#newcode6 ChangeLog:6: argument. Now matches new JSC behaviour. Chromium bug ...

9 years, 1 month ago (2011-10-26 13:29:52 UTC) #2

Kevin Millikin (Chromium)

9 years, 1 month ago (2011-10-27 09:09:03 UTC) #3

http://codereview.chromium.org/8390049/diff/1003/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/8390049/diff/1003/ChangeLog#newcode41
ChangeLog:41: Changed evaluation order for > and <= to match ES5 instead of ES3.
Just a pedantic nit: evaluation order is the same for both ES3 and ES5 (left to
right).  The order of conversion changed.

Expand Messages | Collapse Messages

Issue 8390049: Prepare push to trunk. Now working on 3.7.2 (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages