Fix identity hash code function to respect flag.

Fix identity hash code function to respect flag.

The flag passed to JSObject::GetIdentityHash() was not respected so far
and an indentity hash code was generated even when the flag requested
not to do so. This could lead to a rare corner cases (for which a test
case was added) where a GC request would have been dropped.

R=rossberg@chromium.org
TEST=cctest/test-dictionary

Committed: http://code.google.com/p/v8/source/detail?r=9801

[Michael Starzinger, 2011-10-26 12:16:31]

PTAL.

[rossberg, 2011-10-26 12:19:48]

lgtm

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc
File test/cctest/test-dictionary.cc (right):

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#...
test/cctest/test-dictionary.cc:79: CHECK_NE(key->GetIdentityHash(OMIT_CREATION),
HEAP->undefined_value());
Why not check for isSmi?

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#...
test/cctest/test-dictionary.cc:87: CHECK_NE(key->GetIdentityHash(OMIT_CREATION),
HEAP->undefined_value());
Same here.

[Michael Starzinger, 2011-10-26 12:25:16]

Added new patch set. Landed.

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc
File test/cctest/test-dictionary.cc (right):

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#...
test/cctest/test-dictionary.cc:79: CHECK_NE(key->GetIdentityHash(OMIT_CREATION),
HEAP->undefined_value());
On 2011/10/26 12:19:48, rossberg wrote:
> Why not check for isSmi?

Done.

http://codereview.chromium.org/8390047/diff/1/test/cctest/test-dictionary.cc#...
test/cctest/test-dictionary.cc:87: CHECK_NE(key->GetIdentityHash(OMIT_CREATION),
HEAP->undefined_value());
On 2011/10/26 12:19:48, rossberg wrote:
> Same here.

Done.