Issue 8390046: Add a debug check to verify that FileSystemCallbackDispatcher is not NULL in FileSystemOperation.

Issue 8390046: Add a debug check to verify that FileSystemCallbackDispatcher is not NULL in FileSystemOperation. (Closed)

Created:
9 years, 1 month ago by Oleg Eterevsky

Modified:
9 years, 1 month ago

Reviewers:
kinuko

CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a debug check to verify that FileSystemCallbackDispatcher is not NULL in FileSystemOperation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107601

Patch Set 3 : '' #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	webkit/fileapi/file_system_operation.cc	View	1 2	14 chunks	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinuko

http://codereview.chromium.org/8390046/diff/1/webkit/fileapi/file_system_operation.cc File webkit/fileapi/file_system_operation.cc (right): http://codereview.chromium.org/8390046/diff/1/webkit/fileapi/file_system_operation.cc#newcode83 webkit/fileapi/file_system_operation.cc:83: DCHECK(dispatcher); s/dispatcher/dispatcher_/ here and everywhere?

9 years, 1 month ago (2011-10-26 12:09:26 UTC) #2

Oleg Eterevsky

9 years, 1 month ago (2011-10-26 12:19:24 UTC) #3

kinuko

9 years, 1 month ago (2011-10-27 02:10:36 UTC) #4

lgtm (mod nit)

Thanks!

http://codereview.chromium.org/8390046/diff/4/webkit/fileapi/file_system_oper...
File webkit/fileapi/file_system_operation.cc (right):

http://codereview.chromium.org/8390046/diff/4/webkit/fileapi/file_system_oper...
webkit/fileapi/file_system_operation.cc:83: DCHECK(dispatcher_ != NULL);
nit: DCHECK(dispatcher_.get()) might be more common

Expand Messages | Collapse Messages