Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/ui/ui_test.cc

Issue 8390041: Call VerifyCleanExit in TerminateBrowser. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_test.cc
===================================================================
--- chrome/test/ui/ui_test.cc (revision 107321)
+++ chrome/test/ui/ui_test.cc (working copy)
@@ -762,6 +762,7 @@
void UITest::TerminateBrowser() {
launcher_->TerminateBrowser();
+ VerifyCleanExit();
Paweł Hajdan Jr. 2011/10/26 18:38:20 Could you remove VerifyCleanExit from the callers
achuithb 2011/10/26 18:55:44 Done.
}
void UITest::NavigateToURLAsync(const GURL& url) {
@@ -803,8 +804,6 @@
return false;
}
-// TODO(achuith): Call VerifyCleanExit from TerminateBrowser.
-// http://crbug.com/101390
void UITest::VerifyCleanExit() {
// Make sure the UMA metrics say we didn't crash.
scoped_ptr<DictionaryValue> local_prefs(GetLocalState());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698