Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 8390041: Call VerifyCleanExit in TerminateBrowser. (Closed)

Created:
9 years, 1 month ago by achuithb
Modified:
9 years, 1 month ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Call VerifyCleanExit in TerminateBrowser. BUG=101390 TEST=ui tests continue to pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107622

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : review feedback #

Patch Set 4 : missed a file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -30 lines) Patch
M chrome/browser/ui/tests/browser_uitest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/unload_uitest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/ui/ui_test.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 2 2 chunks +21 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
achuithb
Try server runs: http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/56378 http://build.chromium.org/p/tryserver.chromium/builders/win/builds/63182 http://build.chromium.org/p/tryserver.chromium/builders/linux_asan/builds/109 http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/16052 http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/56625 http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/11494
9 years, 1 month ago (2011-10-26 18:33:06 UTC) #1
Paweł Hajdan Jr.
http://codereview.chromium.org/8390041/diff/1002/chrome/test/ui/ui_test.cc File chrome/test/ui/ui_test.cc (right): http://codereview.chromium.org/8390041/diff/1002/chrome/test/ui/ui_test.cc#newcode765 chrome/test/ui/ui_test.cc:765: VerifyCleanExit(); Could you remove VerifyCleanExit from the callers and ...
9 years, 1 month ago (2011-10-26 18:38:20 UTC) #2
achuithb
PTAL Pawel. http://codereview.chromium.org/8390041/diff/1002/chrome/test/ui/ui_test.cc File chrome/test/ui/ui_test.cc (right): http://codereview.chromium.org/8390041/diff/1002/chrome/test/ui/ui_test.cc#newcode765 chrome/test/ui/ui_test.cc:765: VerifyCleanExit(); On 2011/10/26 18:38:20, Paweł Hajdan Jr. ...
9 years, 1 month ago (2011-10-26 18:55:44 UTC) #3
Paweł Hajdan Jr.
9 years, 1 month ago (2011-10-26 19:00:17 UTC) #4
LGTM thanks.

Powered by Google App Engine
This is Rietveld 408576698