runtime/vm/stub_code.h - Issue 8390021: Cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code.h

Issue 8390021: Cleanups. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code.h

===================================================================

--- runtime/vm/stub_code.h (revision 722)

+++ runtime/vm/stub_code.h (working copy)

@@ -33,7 +33,11 @@

V(FixCallersTarget) \

V(Deoptimize) \

-// TODO(regis): Is it OK for the stubs above to refer to Object::null()?

+// Is it permitted for the stubs above to refer to Object::null(), which is

+// allocated in the VM isolate and shared across all isolates.

+// However, in cases where a simple GC-safe placeholder is needed on the stack,

+// using Smi 0 instead of Object::null() is slightly more efficient, since a Smi

+// does not require relocation.

// List of stubs created per isolate, these stubs could potentially contain

// embedded objects and hence cannot be shared across isolates.

« no previous file with comments | « runtime/vm/parser.cc ('k') | tests/language/language.status » ('j') | no next file with comments »