Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: src/hydrogen-instructions.h

Issue 8387066: Fix bug introduced by my refactoring of bitwise HIR instructions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3038 matching lines...) Expand 10 before | Expand all | Expand 10 after
3049 op == Token::BIT_XOR); 3049 op == Token::BIT_XOR);
3050 } 3050 }
3051 3051
3052 Token::Value op() const { return op_; } 3052 Token::Value op() const { return op_; }
3053 3053
3054 virtual bool IsCommutative() const { return true; } 3054 virtual bool IsCommutative() const { return true; }
3055 3055
3056 DECLARE_CONCRETE_INSTRUCTION(Bitwise) 3056 DECLARE_CONCRETE_INSTRUCTION(Bitwise)
3057 3057
3058 protected: 3058 protected:
3059 virtual bool DataEquals(HValue* other) { return true; } 3059 virtual bool DataEquals(HValue* other) {
3060 return op() == HBitwise::cast(other)->op();
3061 }
3060 3062
3061 virtual Range* InferRange(); 3063 virtual Range* InferRange();
3062 3064
3063 private: 3065 private:
3064 Token::Value op_; 3066 Token::Value op_;
3065 }; 3067 };
3066 3068
3067 3069
3068 class HShl: public HBitwiseBinaryOperation { 3070 class HShl: public HBitwiseBinaryOperation {
3069 public: 3071 public:
(...skipping 1212 matching lines...) Expand 10 before | Expand all | Expand 10 after
4282 4284
4283 DECLARE_CONCRETE_INSTRUCTION(In) 4285 DECLARE_CONCRETE_INSTRUCTION(In)
4284 }; 4286 };
4285 4287
4286 #undef DECLARE_INSTRUCTION 4288 #undef DECLARE_INSTRUCTION
4287 #undef DECLARE_CONCRETE_INSTRUCTION 4289 #undef DECLARE_CONCRETE_INSTRUCTION
4288 4290
4289 } } // namespace v8::internal 4291 } } // namespace v8::internal
4290 4292
4291 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 4293 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698