Enable default object tracking no Mac

Enable default object tracking no Mac

We had trouble with base_unittests before, so we
ifdef'ed out the larger landing.  This tiny
switch CL will turn it on for the Mac, but can
be quickly reverted if there is a problem.

Scott Hess was able to debug and identify the
cause of the problem (yeah Scott!!!!).  I think
the code we landed corrects for the issue he identified,
and this should prove it (or get reverted trying).

r=rtenneti,shess
bug=101856
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108072

[Scott Hess - ex-Googler, 2011-10-31 23:33:48]

So this'll work off trunk if I patch it in and try it?

[jar (doing other things), 2011-10-31 23:43:49]

For sure!

On Mon, Oct 31, 2011 at 4:33 PM, <shess@chromium.org> wrote:

> So this'll work off trunk if I patch it in and try it?
>
>
http://codereview.chromium.**org/8387059/<http://codereview.chromium.org/8387...
>

[Scott Hess - ex-Googler, 2011-10-31 23:49:41]

On 2011/10/31 23:33:48, shess wrote:
> So this'll work off trunk if I patch it in and try it?

LGTM. Patched it in and tried it, and it doesn't seem to do the thing with the
crashing.

[commit-bot: I haz the power, 2011-10-31 23:55:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/8387059/1

[Scott Hess - ex-Googler, 2011-10-31 23:56:51]

On 2011/10/31 23:49:41, shess wrote:
> On 2011/10/31 23:33:48, shess wrote:
> > So this'll work off trunk if I patch it in and try it?
> 
> LGTM. Patched it in and tried it, and it doesn't seem to do the thing with the
> crashing.

Jim has to go.  I'm going to press the Commit button on his behalf.  I'll
monitor, but just in case, if you notice issues please revert this change first,
then the other listed on the bug ...

[Also, to be fair - Jim has to go for reasons of Halloween, and I have kids of a
certain age myself, so ...]

[commit-bot: I haz the power, 2011-11-01 00:57:28]

Try job failure for 8387059-1 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Scott Hess - ex-Googler, 2011-11-01 04:18:49]

On 2011/11/01 00:57:28, I haz the power (commit-bot) wrote:
> Try job failure for 8387059-1 (retry) on linux_rel for step "ui_tests".
> It's a second try, previously, step "ui_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

OK, that made no sense at all, given the change.  Ima press it again.

[Scott Hess - ex-Googler, 2011-11-01 04:20:56]

On 2011/11/01 04:18:49, shess wrote:
> On 2011/11/01 00:57:28, I haz the power (commit-bot) wrote:
> > Try job failure for 8387059-1 (retry) on linux_rel for step "ui_tests".
> > It's a second try, previously, step "ui_tests" failed.
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
> 
> OK, that made no sense at all, given the change.  Ima press it again.

I can't?  Sorry, Jim, the button isn't working just now.

[jar (doing other things), 2011-11-01 04:50:39]

I manually committed it... so there is a good excuse for precluding
complying with additional checkboxes ;-).

Thanks for trying to land this... I saw it failed on an (inconsequential)
trybot, and was retrying... but by manually landing it, it just "got done"
and I was around to watch it land.

Thanks again fro the debugging assistance... and for taking a shot at
seeing this land!,

Jim

On Mon, Oct 31, 2011 at 9:20 PM, <shess@chromium.org> wrote:

> On 2011/11/01 04:18:49, shess wrote:
>
>> On 2011/11/01 00:57:28, I haz the power (commit-bot) wrote:
>> > Try job failure for 8387059-1 (retry) on linux_rel for step "ui_tests".
>> > It's a second try, previously, step "ui_tests" failed.
>> >
>>
>
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_rel&**number=268<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=268>
>
>  OK, that made no sense at all, given the change.  Ima press it again.
>>
>
> I can't?  Sorry, Jim, the button isn't working just now.
>
>
http://codereview.chromium.**org/8387059/<http://codereview.chromium.org/8387...
>

[Scott Hess - ex-Googler, 2011-11-01 05:03:25]

On 2011/11/01 04:50:39, jar wrote:
> I manually committed it... so there is a good excuse for precluding
> complying with additional checkboxes ;-).

hahahah.  did not even occur to me to look.