Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8387053: regex fixes in base.gypi for android files. (Closed)

Created:
9 years, 1 month ago by John Grabowski
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, brettw-cc_chromium.org, Tao Bai
Visibility:
Public.

Description

regex fixes in base.gypi for android files. Follow-up from http://codereview.chromium.org/8387042/ BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M base/base.gypi View 1 chunk +14 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Grabowski
9 years, 1 month ago (2011-10-31 22:43:47 UTC) #1
Mark Mentovai
LGTM. Thanks for the quick follow-up.
9 years, 1 month ago (2011-10-31 23:31:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/8387053/1
9 years, 1 month ago (2011-11-01 16:58:15 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 18:13:52 UTC) #4 
Change committed as 108135

Powered by Google App Engine
This is Rietveld 408576698