Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: runtime/vm/parser.cc

Issue 8387046: Fix parsing of named parameters (issue 243). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/src/NamedParameters9NegativeTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 970)
+++ runtime/vm/parser.cc (working copy)
@@ -930,9 +930,7 @@
// Parse positional parameters.
ParseFormalParameters(allow_explicit_default_values,
params);
- if (CurrentToken() == Token::kLBRACK) {
- ASSERT(!params->has_named_optional_parameters);
- params->has_named_optional_parameters = true;
+ if (params->has_named_optional_parameters) {
// Parse named optional parameters.
ParseFormalParameters(allow_explicit_default_values,
params);
@@ -961,6 +959,7 @@
if (!params->has_named_optional_parameters &&
(CurrentToken() == Token::kLBRACK)) {
// End of normal parameters, start of named parameters.
+ params->has_named_optional_parameters = true;
return;
}
ParseFormalParameter(allow_explicit_default_values, params);
« no previous file with comments | « no previous file | tests/language/src/NamedParameters9NegativeTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698