Android build fixes.

Android build fixes.

Get base_unittests compiling on Android again.  Fix android deps setup
script to work when run, not just when re-run.

BUG=
TEST=

[michaelbai, 2011-10-31 20:06:17]

http://codereview.chromium.org/8387042/diff/1/build/install-build-deps-androi...
File build/install-build-deps-android.sh (right):

http://codereview.chromium.org/8387042/diff/1/build/install-build-deps-androi...
build/install-build-deps-android.sh:117: done
What about upgrade to Android 4.0 SDK, which might fix this issue.

[John Grabowski, 2011-10-31 20:54:48]

http://codereview.chromium.org/8387042/diff/1/build/install-build-deps-androi...
File build/install-build-deps-android.sh (right):

http://codereview.chromium.org/8387042/diff/1/build/install-build-deps-androi...
build/install-build-deps-android.sh:117: done
On 2011/10/31 20:06:17, michaelbai wrote:
> What about upgrade to Android 4.0 SDK, which might fix this issue.

That's a good idea; lets do that as follow-up

[michaelbai, 2011-10-31 20:56:44]

lgtm

As we discussed, let's defer the upgrade

[commit-bot: I haz the power, 2011-10-31 22:22:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/8387042/1

[commit-bot: I haz the power, 2011-10-31 22:22:04]

Presubmit check for 8387042-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: base/base.gypi

[Mark Mentovai, 2011-10-31 22:27:21]

LGTM for base OWNERS review.

The comments can be fixed in a follow-up by whomever. Not critical. This can
land as-is.

http://codereview.chromium.org/8387042/diff/1/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8387042/diff/1/base/base.gypi#newcode438
base/base.gypi:438: ['exclude', '^files/file_path_watcher_kqueue.cc'],
In this entire section:

The dots should be escaped with backslashes, and the ends of the strings should
be anchored with $ (dollar signs).

As an alternative, use sources! to list excludes by name instead of regex.

http://codereview.chromium.org/8387042/diff/1/base/base.gypi#newcode449
base/base.gypi:449: ['exclude', '^android/'],
This one item is an exception, it needs to be excluded by regex, and this regex
is already correct.

[commit-bot: I haz the power, 2011-10-31 22:29:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/8387042/1

[commit-bot: I haz the power, 2011-10-31 23:23:45]

Try job failure for 8387042-1 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-01 16:57:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/8387042/1

[commit-bot: I haz the power, 2011-11-01 18:18:27]

Can't apply patch for file base/base.gypi.
While running patch -p1 --forward --force;
patching file base/base.gypi
Hunk #1 FAILED at 435.
1 out of 1 hunk FAILED -- saving rejects to file base/base.gypi.rej

[John Grabowski, 2011-11-01 18:33:20]

On 2011/11/01 18:18:27, I haz the power (commit-bot) wrote:
> Can't apply patch for file base/base.gypi.
> While running patch -p1 --forward --force;
> patching file base/base.gypi
> Hunk #1 FAILED at 435.
> 1 out of 1 hunk FAILED -- saving rejects to file base/base.gypi.rej

Abandoning this CL; conflicting area obsoleted by
http://codereview.chromium.org/8387053/ which has landed. 
install-build-deps-android.sh change moved to distinct CL.