Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: runtime/lib/growable_array.dart

Issue 8387035: FIx issue 261: throw exception if index if idnexed oeprators if lists Array and GrowableArray is ... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/array.cc ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/growable_array.dart
===================================================================
--- runtime/lib/growable_array.dart (revision 957)
+++ runtime/lib/growable_array.dart (working copy)
@@ -117,6 +117,9 @@
}
T operator [](int index) {
+ if (index is !int) {
+ throw new IllegalArgumentException("[] with $index");
+ }
if (index >= _length) {
throw new IndexOutOfRangeException(index);
}
@@ -124,7 +127,10 @@
}
void operator []=(int index, T value) {
- if (index >= _length) {
+ if (index is !int) {
+ throw new IllegalArgumentException("[]= with $index");
+ }
+ if (index >= _length) {
throw new IndexOutOfRangeException(index);
}
backingArray[index] = value;
« no previous file with comments | « runtime/lib/array.cc ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698