Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8387033: [Web UI Options] For overlays that have >1 button-strip, reverse order of all (in views). (Closed)

Created:
9 years, 1 month ago by binji
Modified:
9 years, 1 month ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Web UI Options] For overlays that have >1 button-strip, reverse order of all (in views). BUG=102303 TEST=Run views chrome. Go to chrome://settings/personal. Sign in to sync. Click "Advanced". OK button should be on left. In non-views chrome (mac, linux), OK button should be on right. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/resources/options/options_page.js View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
I checked in codesearch -- AFAICT, the sync_setup_overlay is the only overlay that has multiple ...
9 years, 1 month ago (2011-10-31 17:26:13 UTC) #1
binji
On 2011/10/31 17:26:13, binji wrote: > I checked in codesearch -- AFAICT, the sync_setup_overlay is ...
9 years, 1 month ago (2011-10-31 17:28:49 UTC) #2
csilv
lgtm
9 years, 1 month ago (2011-10-31 18:13:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8387033/1
9 years, 1 month ago (2011-10-31 20:22:15 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-31 21:42:26 UTC) #5
Change committed as 108014

Powered by Google App Engine
This is Rietveld 408576698