Issue 8387031: String changes for sign in promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8387031: String changes for sign in promo (Closed)

Created:
9 years, 1 month ago by sail

Modified:
9 years, 1 month ago

Reviewers:
tmccoy, jeffreyc, binji

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

String changes for sign in promo Some last minute string changes for sign in promo. BUG=102169, 102171, 102173 TEST= TBR=binji@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107972

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	chrome/app/generated_resources.grd	View		3 chunks	+6 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/webui/sync_setup_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jeffreyc

9 years, 1 month ago (2011-10-31 18:32:04 UTC) #3

LGTM

(not sure if I needed to do that? :)

On Mon, Oct 31, 2011 at 9:38 AM, <binji@chromium.org> wrote:

> On 2011/10/31 16:34:01, sail wrote:
>
> lgtm
>
>
http://codereview.chromium.**org/8387031/<http://codereview.chromium.org/8387...
>

Expand Messages | Collapse Messages