Issue 8387027: Make the irregexp interpreter throw on stack overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8387027: Make the irregexp interpreter throw on stack overflow. (Closed)

Created:
9 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make the irregexp interpreter throw on stack overflow. BUG=v8:904 Committed: http://code.google.com/p/v8/source/detail?r=9780

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -32 lines)			Patch
M	src/interpreter-irregexp.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/interpreter-irregexp.cc	View	5 chunks	+19 lines, -18 lines	0 comments	Download
M	src/jsregexp.cc	View	1 chunk	+10 lines, -8 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

http://codereview.chromium.org/8387027/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): http://codereview.chromium.org/8387027/diff/1/src/jsregexp.cc#newcode519 src/jsregexp.cc:519: isolate->StackOverflow(); Do we do this for compiled regexps?

9 years, 2 months ago (2011-10-25 12:58:41 UTC) #2

Lasse Reichstein

9 years, 2 months ago (2011-10-25 13:27:09 UTC) #3

Erik Corry

9 years, 2 months ago (2011-10-25 13:29:25 UTC) #4

LGTM if the tests all pass in debug mode.  The regexp interpreter is not used on
any target at the moment so it won't be run by the build bots.

Expand Messages | Collapse Messages