Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 8387020: Make GetAnchorPoint non const. (Closed)

Created:
9 years, 2 months ago by alicet1
Modified:
9 years, 1 month ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Make GetAnchorPoint non const. This allows the delegate view to call methods like GetPreferredSize() from children views, which is non-const method. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M views/bubble/bubble_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M views/bubble/bubble_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
alicet1
9 years, 2 months ago (2011-10-25 06:06:46 UTC) #1
msw
LGTM
9 years, 2 months ago (2011-10-25 20:56:56 UTC) #2
alicet1
ben, for approval?
9 years, 2 months ago (2011-10-25 22:48:02 UTC) #3
Ben Goodger (Google)
lgtm
9 years, 2 months ago (2011-10-25 22:55:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alicet@chromium.org/8387020/1
9 years, 2 months ago (2011-10-26 00:55:05 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-10-26 04:20:43 UTC) #6
Change committed as 107295

Powered by Google App Engine
This is Rietveld 408576698