Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 8387016: Move some Autofill processing logic on form submit to a background thread. (Closed)

Created:
9 years, 2 months ago by Ilya Sherman
Modified:
9 years, 1 month ago
Reviewers:
dhollowa
CC:
chromium-reviews, GeorgeY, Avi (use Gerrit), creis+watch_chromium.org, Paweł Hajdan Jr., ajwong+watch_chromium.org, dyu1, brettw-cc_chromium.org, Ilya Sherman, dhollowa
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move some Autofill processing logic on form submit to a background thread. BUG=76992 TEST=Autofill continues to upload form data to the crowdsourcing server Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108162

Patch Set 1 #

Patch Set 2 : Moar scoped_refptr's #

Patch Set 3 : Fix tests #

Patch Set 4 : Rebase #

Patch Set 5 : Don't rely on any particular order of evaluation for the arguments to PostTaskAndReply #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -170 lines) Patch
M chrome/browser/autofill/autofill_manager.h View 1 2 3 7 chunks +19 lines, -8 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 3 4 7 chunks +105 lines, -54 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 1 2 3 7 chunks +88 lines, -73 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 2 3 21 chunks +82 lines, -33 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
9 years, 2 months ago (2011-10-25 22:06:23 UTC) #1
Ilya Sherman
This issue is now ready for review -- please take a look :)
9 years, 1 month ago (2011-11-01 00:33:19 UTC) #2
dhollowa
LGTM. My only question was regarding letting the upload happen on the FILE thread to, ...
9 years, 1 month ago (2011-11-01 01:27:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8387016/9001
9 years, 1 month ago (2011-11-01 19:24:57 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 20:36:03 UTC) #5
Change committed as 108162

Powered by Google App Engine
This is Rietveld 408576698