Close all panels originated by the extension when extension unloads.

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 00d726e365e8d5b5dffe42d9c2f0f4243db1d44a..d6c8b3d0cd2f728cd8e81ee6876f3c3c5bde3424 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -4284,8 +4284,16 @@ void Browser::Observe(int type,
       TabStripModel* model = tab_handler_->GetTabStripModel();
       for (int i = model->count() - 1; i >= 0; --i) {
         TabContents* tc = model->GetTabContentsAt(i)->tab_contents();
-        if (tc->GetURL().SchemeIs(chrome::kExtensionScheme) &&
-            tc->GetURL().host() == extension->id()) {
+        bool close_tab_contents =
+            tc->GetURL().SchemeIs(chrome::kExtensionScheme) &&
+            tc->GetURL().host() == extension->id();
+        if (!close_tab_contents) {

[jennb, 2011/10/25 17:32:16]

Should be a way to do what you want without adding panel-specific logic each
time through the loop for every tab in  every browser.

Another thought: Should popups opened by an extension to a different domain also
be forced to close when extension is unloaded? What about tabs?

[prasadt, 2011/10/25 18:21:20]

What I'm doing is panels specific though. I want to close all non-extension
panels when the extension that opened them is uninstalled.

In the non-panel case, unloading an extension does not close non-extension
tabs/windows opened by another extension. Makes sense, as these are
indistinguishable from other normal tabs/windows and it would be strange for
them to close on the user when an extension is uninstalled.
What I said above. Also if we were to do it, it would be a big enough change in
extensions behavior that it'll need design input from the extensions team.

+          // We want to close all panels originated by the unloaded extension.
+          close_tab_contents =
+              (web_app::GetExtensionIdFromApplicationName(app_name_) ==
+               extension->id()) && type_ == TYPE_PANEL;
+        }
+        if (close_tab_contents) {
           CloseTabContents(tc);
         }
       }