Close all panels originated by the extension when extension unloads.

chrome/browser/ui/browser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // OS_WIN
@@ skipping 4254 matching lines @@
     case chrome::NOTIFICATION_EXTENSION_UNLOADED: {
       if (window()->GetLocationBar())
         window()->GetLocationBar()->UpdatePageActions();
 
       // Close any tabs from the unloaded extension.
       const Extension* extension =
           content::Details<UnloadedExtensionInfo>(details)->extension;
       TabStripModel* model = tab_handler_->GetTabStripModel();
       for (int i = model->count() - 1; i >= 0; --i) {
         TabContents* tc = model->GetTabContentsAt(i)->tab_contents();
-        if (tc->GetURL().SchemeIs(chrome::kExtensionScheme) &&
-            tc->GetURL().host() == extension->id()) {
+        bool close_tab_contents =
+            tc->GetURL().SchemeIs(chrome::kExtensionScheme) &&
+            tc->GetURL().host() == extension->id();
+        // We want to close all panels originated by the unloaded extension.
+        close_tab_contents = close_tab_contents ||
+            ((web_app::GetExtensionIdFromApplicationName(app_name_) ==

[jennb, 2011/10/28 21:12:27]

I would reverse the check to have type_ == TYPE_PANEL first. It's less expensive
than working with the app_name.

[jennb, 2011/10/28 21:12:27]

Will this work correctly if there is no app name?

[prasadt, 2011/10/28 21:53:28]

Done.

[prasadt, 2011/10/28 21:53:28]

Yes. GetExtensionIdFromApplicationName just returns an empty string. Also the
test covers it, the first browser window created does not have an app_name_.

+             extension->id()) && type_ == TYPE_PANEL);
+        if (close_tab_contents) {
           CloseTabContents(tc);
         }
       }
 
       break;
     }
 
     case chrome::NOTIFICATION_EXTENSION_PROCESS_TERMINATED: {
       Profile* profile = content::Source<Profile>(source).ptr();
       if (profile_->IsSameProfile(profile) && window()->GetLocationBar())
@@ skipping 1223 matching lines @@
 }
 
 void Browser::UpdateFullscreenExitBubbleContent() {
   GURL url;
   if (fullscreened_tab_)
     url = fullscreened_tab_->tab_contents()->GetURL();
 
   window_->UpdateFullscreenExitBubbleContent(
       url, GetFullscreenExitBubbleType());
 }